Differential D22236

[startplamsa-x11] Fix GTK scaling
ClosedPublic
Actions

Authored by broulik on Jul 3 2019, 11:31 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:1337ae5e0dbb: [startplamsa-x11] Fix GTK scaling
Summary

ScreenScaleFactors is a list of scales per output. We want to read the ScaleFactor number for GTK instead.
Also, floor the number so that when you use e.g. 2.5x scaling you still get some scaling out of GTK apps still.

Test Plan

Logged in, my GTK apps were scaled properly again.
Changed scale factor to 2.4. Qt apps were bigger and GTK apps were still large. Since the font DPI is also scaled fractionally, GTK apps still looks virtually the same size despite only scaling 2x.
Changed scale factor to 1.9. Qt apps were big, GTK apps were smaller as they didn't scale.

(I can revert/split out that flooring change if you want but the rest is a genuine bugfix)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 3 2019, 11:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2019, 11:31 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 3 2019, 11:31 AM
apol accepted this revision.Jul 3 2019, 2:56 PM
This revision is now accepted and ready to land.Jul 3 2019, 2:56 PM
Closed by commit R120:1337ae5e0dbb: [startplamsa-x11] Fix GTK scaling (authored by broulik). · Explain WhyJul 3 2019, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mstartkde/startplasma-x11.cpp (10 lines)

Diff 61077

View Options

startkde/startplasma-x11.cpp

Loading...