Differential D2222

[Notifications Dataengine] Fix default timeout
ClosedPublic
Actions

Authored by broulik on Jul 19 2016, 2:22 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R120:c521b596e043: [Notifications Dataengine] Fix default timeout
R871:c521b596e043: [Notifications Dataengine] Fix default timeout
Summary

As per notification spec the value "0" means "persistent notification" whereas "-1" means "server default timeout", so when no timeout is explicitly specified, it will always yielded a persistent notification.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5311.Jul 19 2016, 2:22 PM
broulik retitled this revision from to [Notifications Dataengine] Fix default timeout.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 19 2016, 2:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this object.Jul 19 2016, 2:30 PM
graesslin accepted this revision.Jul 19 2016, 2:34 PM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jul 19 2016, 2:34 PM
Closed by commit R120:c521b596e043: [Notifications Dataengine] Fix default timeout (authored by broulik). · Explain WhyJul 19 2016, 8:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5330

View Options

dataengines/notifications/notifications.operations

Loading...