[Tab] Fix sizing
ClosedPublic

Authored by broulik on Jul 2 2019, 2:19 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R858:bf14f6f0687e: [Tab] Fix sizing
Summary

Replicates QTabBar::tabSizeHint for desktop style. Not every style implements custom size hints for tabs, where it would just fall through to returning sizeFromContents as it is passed in, leading to tiny tabs.

BUG: 409390

Test Plan

Before (Breeze)


Before (Fusion, slightly broken, we might not take into account the vertical offset for inactive tabs?)

Before (Kvantum, hideous as usual)

Before (QtCurve, unusable)

After (Breeze, no change)


After (Fusion, more correct now, doesn't fall back to 2 * grid unit anymore)

After (Kvantum, even more hideous)

After (QtCurve, now mostly correct, not sure why the width is off)

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 2 2019, 2:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2019, 2:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 2 2019, 2:19 PM
broulik edited the summary of this revision. (Show Details)
mart accepted this revision.Sep 16 2019, 10:30 AM
This revision is now accepted and ready to land.Sep 16 2019, 10:30 AM
This revision was automatically updated to reflect the committed changes.