change username labels to e-mail address instead
ClosedPublic

Authored by sitter on Jul 2 2019, 12:29 PM.

Details

Summary

users in bugzilla are always identified by their email address so it makes
no sense to label the input username.

calling it email address is also consistent with the bugzilla webui itself.

that said, we actually spell it inconstantly email or e-mail across
software. the most prominent cases in kdepim though spell it
"E-mail Address" for input labels. so, going with that

for ease of reading I'm leaving the code variables and the likes to say
username as this more obviously ties to the related password variables.

BUG: 375462
FIXED-IN: 5.17.0

Test Plan

login page now has an email address label

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 2 2019, 12:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2019, 12:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jul 2 2019, 12:29 PM
apol accepted this revision.Jul 3 2019, 2:11 AM
This revision is now accepted and ready to land.Jul 3 2019, 2:11 AM
This revision was automatically updated to reflect the committed changes.