Differential D22180

[mobile/wifi] Use default height for ConnectionItemDelegate
ClosedPublic
Actions

Authored by nicolasfella on Jun 30 2019, 10:25 PM.

Details

Reviewers
jgrulich
mkacej
ngraham
Group Reviewers
Plasma
VDG
Commits
R116:661840636a56: [mobile/wifi] Use default height for ConnectionItemDelegate
Summary

Using the default height of SwipeListItem gives a more sensible and consistent with other lists look

Test Plan

Before:

After:

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jun 30 2019, 10:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 30 2019, 10:25 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jun 30 2019, 10:25 PM
nicolasfella edited the test plan for this revision. (Show Details)Jun 30 2019, 10:27 PM
nicolasfella added a reviewer: mkacej.
ngraham accepted this revision.Jun 30 2019, 11:12 PM
jgrulich accepted this revision.Jul 1 2019, 5:28 AM
This revision is now accepted and ready to land.Jul 1 2019, 5:28 AM
Closed by commit R116:661840636a56: [mobile/wifi] Use default height for ConnectionItemDelegate (authored by nicolasfella). · Explain WhyJul 1 2019, 8:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60905

View Options

mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml

Loading...