This is another refactoring step towards making Attachment an implicitly
shared value type too. The now deprecated methods will be removed as part
of that switch.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R172 KCalendar Core
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13417 Build 13435: arc lint + arc unit
Comment Actions
What about instead not add any temporary file handling to Attachment?
After all, writeAttachmentToTempFile() seems to be used only in two places (both in calendarsupport):
- src/incidenceattachmentmodel.cpp
- src/utils.cpp
At least (2) looks easy enough to port away: in non-uri attachments, create the destination file, and write data() directly to it (without KIO).
Comment Actions
It's actually even easier, none of the code using this actually seems to be used... Thanks for noticing, I'll remove this altogether then.