Differential D22157

Use debugging category in taglib extractor/writer
ClosedPublic
Actions

Authored by astippich on Jun 29 2019, 2:28 PM.

Details

Reviewers
bruns
Commits
R286:ce0b873f1888: Use debugging category in taglib extractor/writer

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Jun 29 2019, 2:28 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 29 2019, 2:28 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Jun 29 2019, 2:28 PM
bruns added inline comments.Jun 29 2019, 3:50 PM
autotests/CMakeLists.txt
136

use ${KfileMetaDataAutotest_SRCS} instead ...

153

... like done here

src/extractors/CMakeLists.txt
19

please change the ecm_declare_logging_category in src/CMakeLists.txt to a distinct variable for the debug source file, and use it here.

astippich updated this revision to Diff 60843.Jun 29 2019, 6:28 PM
  • use separate debug src
astippich updated this revision to Diff 60844.Jun 29 2019, 6:30 PM
  • adjust writer cmake
bruns accepted this revision.Jun 29 2019, 6:40 PM
This revision is now accepted and ready to land.Jun 29 2019, 6:40 PM
Closed by commit R286:ce0b873f1888: Use debugging category in taglib extractor/writer (authored by astippich). · Explain WhyJun 30 2019, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60850

View Options

autotests/CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/embeddedimagedata.cpp

Loading...
View Options

src/extractors/CMakeLists.txt

Loading...
View Options

src/extractors/taglibextractor.cpp

Loading...
View Options

src/writers/CMakeLists.txt

Loading...
View Options

src/writers/taglibwriter.cpp

Loading...