Some of these variables have been declared protected but can apparently
also be private.
Other minor code style improvements.
Details
Details
- Reviewers
zzag - Group Reviewers
KWin - Commits
- R108:486c2f453402: [platformsupport] Minor code style and class variables access changes
Compiles, Wayland nested session runs.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Some of these variables have been declared protected but can apparently also be private.
That's because SceneOpenGLTexture and OpenGLWindowPixmap are fwends. It's somewhat weird to declare a friend class, which is specific to one scene, in a generic-ish class. On the other hand, we have only one OpenGL scene.
Comment Actions
While there is a friend relation they are not in a parent-child relation. From my understanding conceptually they are both on the same level inside KWin. OpenGLWindowPixmap represents a WindowPixmap in the OpenGl scene while SceneOpenGlTexture represents the actual texture in it. The platform separation is then done one level below in the OpenGlBackend child classes and their respective SceneOpenGLTexturePrivate implementations.