Differential D22087

Build without foreach
AbandonedPublic
Actions

Authored by nicolasfella on Jun 25 2019, 9:04 AM.

Details

Reviewers

None

Group Reviewers

Plasma

Test Plan

Did Plasma things

Diff Detail

Repository

R120 Plasma Workspace

Branch

foreach

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13284
Build 13302: arc lint + arc unit

nicolasfella created this revision.Jun 25 2019, 9:04 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 25 2019, 9:04 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jun 25 2019, 9:04 AM

Harbormaster completed remote builds in B13284: Diff 60630.Jun 25 2019, 9:04 AM

Ping?

+1 overall

dataengines/powermanagement/powermanagementengine.cpp
442	const &
dataengines/share/shareengine.cpp
54	const &
libdbusmenuqt/dbusmenushortcut_p.cpp
60	const &, also this should possibly be transformed into a splitRef.
75	this is already const, no? weirdest foreach in KDE xD 🏅
runners/bookmarks/bookmarksrunner.cpp
86	const &?
runners/bookmarks/browsers/chrome.cpp
54	const&?
runners/bookmarks/browsers/firefox.cpp
102	const &
shell/screenpool.cpp
174	Iterating through keys isn't very optimal, I'd use iterators here.

nicolasfella marked 5 inline comments as done.Aug 20 2019, 2:50 PM

nicolasfella added inline comments.

libdbusmenuqt/dbusmenushortcut_p.cpp
60	Doesn't work trivially because of the token.replace() below
runners/bookmarks/browsers/chrome.cpp
54	Not trivially possible because of the 'new ProfileBookmarks(profile)' below
shell/screenpool.cpp
174	Agreed, but in another patch

Comments

Harbormaster completed remote builds in B15352: Diff 64127.Aug 20 2019, 2:55 PM

nicolasfella abandoned this revision.Dec 6 2020, 4:28 PM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			applets/digital-clock/plugin/timezonemodel.cpp (2 lines)
M			applets/systemtray/container/systemtraycontainer.cpp (3 lines)
M			components/sessionsprivate/sessionsmodel.cpp (2 lines)
M			components/shellprivate/interactiveconsole/interactiveconsole.cpp (6 lines)
M			components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp (9 lines)
M			components/shellprivate/widgetexplorer/widgetexplorer.cpp (11 lines)
M			containmentactions/applauncher/launch.cpp (3 lines)
M			containmentactions/contextmenu/menu.cpp (6 lines)
M			containmentactions/switchactivity/switch.cpp (3 lines)
M			dataengines/activities/activityengine.cpp (9 lines)
M			dataengines/apps/appsengine.cpp (6 lines)
M			dataengines/apps/appsource.cpp (3 lines)
M			dataengines/devicenotifications/ksolidnotify.cpp (4 lines)
M			dataengines/geolocation/geolocation.cpp (6 lines)
M			dataengines/hotplug/hotplugengine.cpp (10 lines)
M			dataengines/mpris2/mpris2engine.cpp (3 lines)
M			dataengines/mpris2/multiplexedservice.cpp (5 lines)
M			dataengines/powermanagement/powermanagementengine.cpp (6 lines)
M			dataengines/share/shareengine.cpp (6 lines)
M			dataengines/soliddevice/soliddeviceengine.cpp (11 lines)
M			dataengines/statusnotifieritem/statusnotifieritem_engine.cpp (4 lines)
M			dataengines/systemmonitor/systemmonitor.cpp (2 lines)
M			dataengines/time/solarsystem.cpp (2 lines)
M			dataengines/time/timeengine.cpp (3 lines)
M			kioslave/applications/kio_applications.cpp (3 lines)
M			kioslave/desktop/kio_desktop.cpp (2 lines)
M			klipper/configdialog.cpp (9 lines)
M			klipper/editactiondialog.cpp (3 lines)
M			klipper/historyurlitem.cpp (2 lines)
M			klipper/urlgrabber.cpp (14 lines)
M			krunner/view.cpp (6 lines)
M			ksmserver/autostart.cpp (6 lines)
M			ksmserver/client.cpp (4 lines)
M			ksmserver/logout.cpp (42 lines)
M			ksmserver/server.cpp (10 lines)
M			ksmserver/shutdown.cpp (4 lines)
M			ksmserver/startup.cpp (4 lines)
M			ksplash/ksplashqml/splashapp.cpp (5 lines)
M			libdbusmenuqt/dbusmenuimporter.cpp (12 lines)
M			libdbusmenuqt/dbusmenushortcut_p.cpp (6 lines)
M			libdbusmenuqt/dbusmenutypes_p.cpp (2 lines)
M			libkworkspace/kdisplaymanager.cpp (16 lines)
M			libtaskmanager/abstractwindowtasksmodel.cpp (3 lines)
M			libtaskmanager/launchertasksmodel.cpp (2 lines)
M			libtaskmanager/startuptasksmodel.cpp (2 lines)
M			libtaskmanager/tasksmodel.cpp (12 lines)
M			libtaskmanager/tasktools.cpp (9 lines)
M			libtaskmanager/virtualdesktopinfo.cpp (4 lines)
M			libtaskmanager/waylandtasksmodel.cpp (10 lines)
M			libtaskmanager/xwindowtasksmodel.cpp (8 lines)
M			logout-greeter/greeter.cpp (3 lines)
M			plasma-windowed/plasmawindowedview.cpp (6 lines)
M			plasmacalendarintegration/holidaysevents.cpp (8 lines)
M			runners/activities/activityrunner.cpp (4 lines)
M			runners/appstream/appstreamrunner.cpp (6 lines)
M			runners/bookmarks/bookmarksrunner.cpp (4 lines)
M			runners/bookmarks/browsers/chrome.cpp (11 lines)
M			runners/bookmarks/browsers/chromefindprofile.cpp (3 lines)
M			runners/bookmarks/browsers/firefox.cpp (6 lines)
M			runners/bookmarks/browsers/opera.cpp (4 lines)
M			runners/bookmarks/fetchsqlite.cpp (3 lines)
M			runners/kill/killrunner.cpp (2 lines)
M			runners/powerdevil/PowerDevilRunner.cpp (4 lines)
M			runners/recentdocuments/recentdocuments.cpp (2 lines)
M			runners/services/servicerunner.cpp (21 lines)
M			runners/sessions/sessionrunner.cpp (2 lines)
M			runners/webshortcuts/webshortcutrunner.cpp (3 lines)
M			runners/windowedwidgets/windowedwidgetsrunner.cpp (3 lines)
M			runners/windows/windowsrunner.cpp (7 lines)
M			shell/containmentconfigview.cpp (8 lines)
M			shell/coronatesthelper.cpp (6 lines)
M			shell/currentcontainmentactionsmodel.cpp (2 lines)
M			shell/panelshadows.cpp (2 lines)
M			shell/screenpool.cpp (3 lines)
M			shell/scripting/appinterface.cpp (12 lines)
M			shell/scripting/applet.cpp (4 lines)
M			shell/scripting/containment.cpp (9 lines)
M			shell/scripting/scriptengine.cpp (10 lines)
M			shell/scripting/scriptengine_v1.cpp (8 lines)
M			shell/shellcorona.cpp (8 lines)
M			soliduiserver/deviceactionsdialog.cpp (4 lines)
M			soliduiserver/soliduiserver.cpp (6 lines)
M			startkde/kcminit/main.cpp (4 lines)
M			wallpapers/image/backgroundlistmodel.cpp (12 lines)
M			wallpapers/image/image.cpp (11 lines)
M			wallpapers/image/slidemodel.cpp (2 lines)