Differential D22008

Enable setting of shortcut for taking a screenshot of only the current screen
ClosedPublic
Actions

Authored by davidre on Jun 22 2019, 5:44 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Spectacle
Commits
R166:707390381fd0: Enable setting of shortcut for taking a screenshot of only the current screen
Summary

Even though we don't set a default for this action the user can set his own
shortcut. For this to work in Spectacle we need the call to GlobalAccel as
a workaround for the same reason as the ones for the other actions.

Test Plan

Set a shortcut, should appear both in global settings and spectacle

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Jun 22 2019, 5:44 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptJun 22 2019, 5:44 PM
davidre requested review of this revision.Jun 22 2019, 5:44 PM
davidedmundson accepted this revision.Jun 22 2019, 6:06 PM
This revision is now accepted and ready to land.Jun 22 2019, 6:06 PM
ngraham accepted this revision.Jun 22 2019, 6:06 PM

Fixes the bug, but I'd like to see what @davidedmundson thinks.

davidre edited the summary of this revision. (Show Details)Jun 22 2019, 6:07 PM
Closed by commit R166:707390381fd0: Enable setting of shortcut for taking a screenshot of only the current screen (authored by davidre). · Explain WhyJun 22 2019, 6:07 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Jun 22 2019, 6:08 PM

You are too fast for me!

Revision Contents
Changeset List

PathPackages
Msrc/SpectacleCore.cpp (3 lines)

Diff 60387

View Options

src/SpectacleCore.cpp

Loading...