Batch MPRIS DBus property changes
ClosedPublic
Actions

Authored by broulik on Jun 22 2019, 1:41 PM.

Details

Reviewers

fvogt

Group Reviewers

Plasma

Commits

R856:8cacb9246b0d: Batch MPRIS DBus property changes

Test Plan

Didn't rename the emitPropertyChange method to queuePropertyChange to keep the changes to a minimum. Might change that separately later

Repository

R856 Plasma Browser Integration

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jun 22 2019, 1:41 PM

There should be a comment somewhere to explain what's happening and why.

host/mprisplugin.h
153 ↗	(On Diff #60347)	Why a pointer?

This revision now requires changes to proceed.Jun 22 2019, 1:59 PM

host/mprisplugin.h
153 ↗	(On Diff #60347)	No particular reason, just that we usually do that..

Timer on stack

+1 LGTM

This revision is now accepted and ready to land.Jun 23 2019, 10:31 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			host/mprisplugin.h (7 lines)
M			host/mprisplugin.cpp (54 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60347			Jun 22 2019, 1:40 PM	★	★
Diff 2	60352			Jun 22 2019, 2:31 PM	★	★
Diff 3	60437	97cd13a	R856:8cacb9246b0d0f5e05046285a06b9beeffb4bd0a	Jun 23 2019, 10:33 AM	★	★