Differential D21927

Use window.postMessage instead of creating a wrapper item
ClosedPublic
Actions

Authored by broulik on Jun 20 2019, 1:40 PM.

Details

Reviewers
davidedmundson
fvogt
Group Reviewers
Plasma
Commits
R856:b1ea6f2de39a: Use window.postMessage instead of creating a wrapper item
Summary

This should make it less invasive by not messing with the website DOM.

Test Plan

Still get album art, artist info, and callbacks on both Chrome and Firefox

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 20 2019, 1:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 20 2019, 1:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 20 2019, 1:40 PM
broulik added inline comments.Jun 20 2019, 2:57 PM
extension/content-script.js
641

Oops :)

fvogt requested changes to this revision.Jun 20 2019, 5:22 PM

Also do some more sanity checks on the input data.

Are those even necessary at that point? Considering that the referenced payload properties can still be literally anything and now even direct objects instead of just stuff converted to JSON and back.

extension/content-script.js
639

Whitespace

641

Yeah, let's keep it "family friendly" ;-)

660

Whitespace

This revision now requires changes to proceed.Jun 20 2019, 5:22 PM
broulik updated this revision to Diff 60186.Jun 21 2019, 8:50 AM
broulik edited the summary of this revision. (Show Details)
  • Cleanup
fvogt accepted this revision.Jul 2 2019, 7:41 AM
This revision is now accepted and ready to land.Jul 2 2019, 7:41 AM
Closed by commit R856:b1ea6f2de39a: Use window.postMessage instead of creating a wrapper item (authored by broulik). · Explain WhyJul 2 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (114 lines)

Diff 60988

View Options

extension/content-script.js

Loading...