Differential D21912

Port notification to qqc2
ClosedPublic
Actions

Authored by astippich on Jun 19 2019, 6:08 PM.

Details

Reviewers
mgallien
Commits
R255:c34de70ea55f: Port notification to qqc2
Summary

Port notification to qqc2

Diff Detail

Repository
R255 Elisa
Branch
qqc2_notification
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12984
Build 13002: arc lint + arc unit
astippich requested review of this revision.Jun 19 2019, 6:08 PM
astippich created this revision.
astippich added a comment.Jun 19 2019, 6:09 PM

Btw, I am unable to trigger this notification by disabling Baloo as it used to, so this is only compile tested right now

mgallien added a comment.Jun 27 2019, 5:35 AM

Thanks for your work. See my comment.

src/qml/TopNotificationItem.qml
115

No need to create an Action element for that and given you still use an onClicked handler, we gain nothing to use an action.

mgallien accepted this revision.Jun 29 2019, 1:10 PM

Thanks

This revision is now accepted and ready to land.Jun 29 2019, 1:10 PM
Closed by commit R255:c34de70ea55f: Port notification to qqc2 (authored by astippich). · Explain WhyJun 29 2019, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/TopNotificationItem.qml (22 lines)

Diff 60084

View Options

src/qml/TopNotificationItem.qml

Loading...