Differential D21877

Hide tooltip when PrivateActionToolButton is pressed
ClosedPublic
Actions

Authored by cblack on Jun 17 2019, 8:21 PM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
Kirigami
Commits
R169:66418f55db9b: Hide tooltip when PrivateActionToolButton is pressed
Summary

The tooltip used to remain even as the button was pressed, now it doesn't/shouldn't.

Test Plan

Look at a bunch of instances of this and make sure the tooltip hides on button press.

Diff Detail

Repository
R169 Kirigami
Branch
hide-tooltip-on-card-action-trigger (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12936
Build 12954: arc lint + arc unit
cblack created this revision.Jun 17 2019, 8:21 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 17 2019, 8:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Jun 17 2019, 8:21 PM
ngraham accepted this revision.Jun 18 2019, 10:55 AM
ngraham added a reviewer: mart.
ngraham added subscribers: mart, ngraham.

@mart?

This revision is now accepted and ready to land.Jun 18 2019, 10:55 AM
ngraham added a comment.Jun 21 2019, 1:34 PM

@mart told me in person that this is good to go. Thanks very much for your contribution @cblack! May it be the first of many more. :)

Closed by commit R169:66418f55db9b: Hide tooltip when PrivateActionToolButton is pressed (authored by cblack, committed by ngraham). · Explain WhyJun 21 2019, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60005

View Options

src/controls/private/PrivateActionToolButton.qml

Loading...