Invert controls direction for process priority slider
ClosedPublic

Authored by kishoreg on Jun 15 2019, 10:04 AM.

Details

Summary

Since low 'nice' values correspond to high priority, the slider labels are inverted so that 'higher' corresponds to a lower nice number. However, this was not done for the slider control, resulting in the arrow keys moving the slider in the direction opposite to that expected by the user. This patch fixes this by setting invertedControls to 'true' for the priority slider.

BUG: 408074

Test Plan
  1. Open Ksysguard.
  2. Go to the tab that lists processes.
  3. Right click on a process and select 'Set Priority'.
  4. Click on the slider that sets the CPU priority.
  5. Press the left and right arrow keys on the keyboard and check if they move the slider in the appropriate direction.

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kishoreg created this revision.Jun 15 2019, 10:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 15 2019, 10:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kishoreg requested review of this revision.Jun 15 2019, 10:04 AM
kishoreg updated this revision to Diff 59864.Jun 15 2019, 10:09 AM

Do the same for the ionice slider too.

cfeck accepted this revision.Jun 16 2019, 2:20 AM
cfeck added a subscriber: cfeck.

Thanks!

This revision is now accepted and ready to land.Jun 16 2019, 2:20 AM
This revision was automatically updated to reflect the committed changes.