[Calculator] Fix popup size and minimum size for expanded version
ClosedPublic

Authored by ngraham on Jun 14 2019, 9:45 PM.

Details

Summary

In D21503, I messed up the popup size and made it iconify at too small a size. This
patch aims to fix that.

Test Plan

I'm not super familiar with this code so I'm not sure it's the right approach, but
it does seem to work:


Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 14 2019, 9:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 14 2019, 9:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 14 2019, 9:45 PM
broulik added inline comments.
applets/calculator/package/contents/ui/calculator.qml
42

Maybe just fixing this to be units.gridUnit times some larger value could fix the initial sizing

ngraham added inline comments.Wed, Jun 19, 6:06 PM
applets/calculator/package/contents/ui/calculator.qml
42

I tried that earlier, but while it works for the expanded version when the widget is in the panel, it doesn't do the trick when the widget is on the desktop.

ngraham updated this revision to Diff 60312.Sat, Jun 22, 10:40 AM

Just use a reasonable hardcoded size, per @davidedmundson's suggestion

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jun 22, 10:43 AM
This revision was automatically updated to reflect the committed changes.