Differential D21799

actually set kaboutdata as application aboutdata
ClosedPublic
Actions

Authored by sitter on Jun 14 2019, 11:08 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R871:bd205d4d2b75: actually set kaboutdata as application aboutdata
Summary

otherwise kcrash won't be able to determine the bugaddress and without
bugaddress the drkonqi catching drkonqi won't know what to do with the
crash.

it ought to be noted that drkonqi will not allow reporting bugs against
drkonqi (not that I fully agree with the rationale)

BUG: 383842
FIXED-IN: 5.16.1

Test Plan
  • killall -SEGV dolphin
  • open drkonqi
  • killall -SEGV drkonqi
  • open drkonqi
  • offers instructions on how to proceed reporting a bug against drkonqi

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 14 2019, 11:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 14 2019, 11:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 14 2019, 11:08 AM
davidedmundson accepted this revision.Jun 14 2019, 11:49 AM
This revision is now accepted and ready to land.Jun 14 2019, 11:49 AM
kossebau added a subscriber: kossebau.Jun 14 2019, 12:13 PM
kossebau added inline comments.
src/main.cpp
89 ↗(On Diff #59784)

This is partially redundant though with all the QCoreApplication::set* above, as well as qa.setDesktopFileName below. Those should be removed then for clean code.

Closed by commit R871:bd205d4d2b75: actually set kaboutdata as application aboutdata (authored by sitter). · Explain WhyJun 14 2019, 1:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (1 line)

Diff 59791

View Options

src/main.cpp

Loading...