Differential D21768

Change tab name format to ProfileName @ Port.
ClosedPublic
Actions

Authored by rizzitello on Jun 12 2019, 2:16 PM.

Details

Reviewers
laysrodrigues
tcanabrava
patrickelectric
Commits
R231:41c84208fb3d: Change tab name format to ProfileName @ Port.
R231:1ae90655c4d0: Change tab name format to ProfileName @ Port.
Summary

I accidentally set the AtCoreInstance name to the devices Baud. This fixes that and add an enhancement to the title that show the Port the device is on. This is helpful because there is currently no way to show the port the device is on after connecting.

Old:

Should show profile name "I3", set to devices baud by mistake.
New:
Profile name @ Port.

Diff Detail

Branch
tabNameUpdate
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12890
Build 12908: arc lint + arc unit
rizzitello requested review of this revision.Jun 12 2019, 2:16 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Jun 12 2019, 2:22 PM
rizzitello added reviewers: laysrodrigues, tcanabrava, patrickelectric.
rizzitello added a project: Atelier.
rizzitello added a subscriber: Atelier.
rizzitello updated this revision to Diff 59655.Jun 12 2019, 2:26 PM
rizzitello edited the summary of this revision. (Show Details)
  • remove unneeed i18n call
patrickelectric accepted this revision.Jun 15 2019, 12:01 PM
This revision is now accepted and ready to land.Jun 15 2019, 12:01 PM
laysrodrigues accepted this revision.Jun 16 2019, 3:06 PM
rizzitello closed this revision.Jun 16 2019, 3:11 PM

Revision Contents
Changeset List

Diff 59921

View Options

src/widgets/atcoreinstancewidget.cpp

Loading...