Fix infinite loop when mThreadingCache is 'corrupted'
ClosedPublic

Authored by aacid on Jun 10 2019, 8:39 PM.

Details

Summary

For some reason i have a mThreadingCache that if you obey with the eyes closed creates loops in the threading and thus kmail gets stuck when trying to show that folder

Test Plan

Folder no longer gets stuck in an infinite loop

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Jun 10 2019, 8:39 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 10 2019, 8:39 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
aacid requested review of this revision.Jun 10 2019, 8:39 PM

I have a folder that always goes into infiinite loop mode. I can test this

tested locally and it works fine!
+1 from me.

I'm not doing a +2 since I don't know what side-effects there might be and I don't know anything about the threading model.

It seems logic for me.
I will test it today to be sure that it doesn't create problem.

Seen this problem on a colleague's machine too, thanks for looking into it!
Looks sane to me, performance impact is linear with depth, should be ok, so +1 from me too.

mlaurent accepted this revision.Jun 11 2019, 7:56 AM

it seems to work here.
+2 :)

This revision is now accepted and ready to land.Jun 11 2019, 7:56 AM
This revision was automatically updated to reflect the committed changes.