Move code to extract legacy window ids from (drop) MIME data into libtm-ng.
ClosedPublic

Authored by hein on Jul 14 2016, 1:48 PM.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 5163.Jul 14 2016, 1:48 PM
hein retitled this revision from to Move code to extract legacy window ids from (drop) MIME data into libtm-ng..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2016, 1:48 PM
mart added a subscriber: mart.Jul 14 2016, 2:57 PM
mart added inline comments.
libtaskmanager/xwindowtasksmodel.h
211

would this cause problems in wayland?

hein marked an inline comment as done.Jul 14 2016, 3:12 PM
hein added inline comments.
libtaskmanager/xwindowtasksmodel.h
211

No, because this is X11-specific code that is never run on Wayland and not built if X11 is not available at build time.

Now, we don't have a solution yet for dragging Wayland windows by reference. Whether we can find a solution that works on both or need different codepaths: Time will tell. For now this is just something we can do on X11 but not on Wayland, like many others - and it's not a new thing, this is old code just moved here.

Note that once the Pager is ported to libtaskmanager both sides will go through libtaskmanager and the TM appley already uses a generic data role (AbstractTasksModel::MimeData) when starting a drag, so we'll have some freedom to design a solution.

For now it's just keeping something already working working while allowing us to drop liblegacytaskmanager and make forward progress :)

mart accepted this revision.Jul 14 2016, 8:38 PM
mart added a reviewer: mart.
mart added inline comments.
libtaskmanager/xwindowtasksmodel.h
211

ok, thx

This revision is now accepted and ready to land.Jul 14 2016, 8:38 PM
This revision was automatically updated to reflect the committed changes.
hein marked an inline comment as done.