Differential D21640

kcm_fonts: Fix tracking of configuration changes
ClosedPublic
Actions

Authored by fvogt on Jun 7 2019, 9:00 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R119:df81b30e11a6: kcm_fonts: Fix tracking of configuration changes
Summary

Sometimes, kcm_fonts wrote garbage into fonts.conf. This was a result of not
initializing variables properly. In addition, toggling the exclude range
checkbox did not enable the Apply button. That's fixed as well now.

Test Plan

Did almost every possible antialiasing settings configuration,
fonts.conf looked as expected.

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.16
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12511
Build 12529: arc lint + arc unit
fvogt created this revision.Jun 7 2019, 9:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 7 2019, 9:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt requested review of this revision.Jun 7 2019, 9:00 AM
bshah accepted this revision.Jun 7 2019, 9:10 AM

Please make sure is properly merged in master/ no merge conflicts are present.

This revision is now accepted and ready to land.Jun 7 2019, 9:10 AM
Closed by commit R119:df81b30e11a6: kcm_fonts: Fix tracking of configuration changes (authored by fvogt). · Explain WhyJun 7 2019, 9:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/fonts/fonts.h (21 lines)
Mkcms/fonts/fonts.cpp (6 lines)

Diff 59318

View Options

kcms/fonts/fonts.h

Loading...
View Options

kcms/fonts/fonts.cpp

Loading...