Don't give up if no results arrive after 500ms

Authored by fvogt on Jun 5 2019, 2:59 PM.



Currently it resets the entire context if no results appear after 500ms,
which means no new results can appear. This makes no sense.

RunnerManager does not emit any matchChanged signal while the runners update
the matches too quickly. The way this delay is implemented can result in never
actually emitting the signal until all runners are done though.
Thus it's actually likely to hit this situation.

BUG: 389611

Test Plan

Test results appear now, even if the first batch of runners is slow.
List of matches still clears if nothing was found.

Diff Detail

R112 Milou
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jun 5 2019, 2:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2019, 2:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt requested review of this revision.Jun 5 2019, 2:59 PM
broulik added a subscriber: broulik.Jun 5 2019, 3:02 PM

Does that by chance also fix the dictionary runner which does network queries that take a while?


more like a flags thing :), also TODO Plasma 6 this way round pls


Yeah please avoid a boolean trap, clearContent(false) isn't very obvious

fvogt updated this revision to Diff 59204.Jun 5 2019, 3:31 PM

Code duplication is better than polluting the API.

fvogt marked 2 inline comments as done.Jun 5 2019, 3:32 PM
fvogt added inline comments.

Done differently now. It's not like the added function would've been useful to call from the outside anyway.

fvogt updated this revision to Diff 59789.Jun 14 2019, 12:24 PM
fvogt marked an inline comment as done.

Remove whitespace change. Will land on Monday if no objections.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 18 2019, 4:56 PM
This revision was automatically updated to reflect the committed changes.