Remove colon (:) prefix when looking up dictionary word

Authored by broulik on Jul 29 2019, 7:11 PM.



The dictionary engine lets us specify a server and dictionary but we don't need any of that, and the engine can deal with just a word (these days?).
More importantly, the key inserted into the m_lockers map is without a colon and since sourceRemoved is also called without it, the wait condition is never met and we time out eventually.
The colon has been in there forever but from current dictionary engine code I don't see why it would be neccessary.

BUG: 376905
FIXED-IN: 5.16.4

Test Plan

5.16 branch?

  • Together with D21605 (or on 5.16 with old milou model) dictionary runner finds stuff again "define test"

Diff Detail

R114 Plasma Addons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 29 2019, 7:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 29 2019, 7:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 29 2019, 7:11 PM
davidedmundson accepted this revision.Jul 29 2019, 10:12 PM
This revision is now accepted and ready to land.Jul 29 2019, 10:12 PM
broulik edited the summary of this revision. (Show Details)Jul 30 2019, 7:02 AM
This revision was automatically updated to reflect the committed changes.
wbauer added a subscriber: wbauer.Aug 7 2019, 5:05 AM

Can this be pushed to the 5.12 branch as well, please?
It's broken in 5.12.8 as well ( was actually reported against 5.12.1), the patch applies cleanly and does fix the problem.

wbauer added a comment.Aug 7 2019, 8:47 AM

Thank you!