This is like a PoC patch for Auth agent.
Details
Diff Detail
- Repository
- R16 KPMCore
- Branch
- auth_agent
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12734 Build 12752: arc lint + arc unit
CMakeLists.txt | ||
---|---|---|
72 | Do this one separately, it's not KF5 frameworks. find_package(PolkitQt5-1 REQUIRED) You might also need if compilation fails | |
src/util/FindPolkitQt-1.cmake | ||
2 ↗ | (On Diff #59073) | Keep original copyright of the file form where you coppied it. It doesn't look like you changed anything here. And even if you changed, you add your own copyright line in addition to keeping old ones. |
src/util/externalcommand_authagent.cpp | ||
123 | Minor: probably too many white lines in this function. |
src/util/externalcommand_authagent.h | ||
---|---|---|
24 | #include <PolkitQt1/Agent/Listener> |
cmake/modules/FindPolkitQt-1.cmake | ||
---|---|---|
1–36 ↗ | (On Diff #59248) | Ok, I just checked, what I need to do to compile.. Remove this file completely. And use find_package(PolkitQt5-1 REQUIRED) Note that it is Qt5, not Qt. |
So far rest seems alright.
CMakeLists.txt | ||
---|---|---|
48 | This is no longer necessary after we link to PolkitQt5-1 instead of PolkitQt-1 |
- Use synchronous versions of register and unregistering authentication agents
- Call authenticationAgentResponseSync() on successfull authentication by the user
@stikonas @cjlcarvalho How can I use QSignalSpy? I tried adding it to target link libraries(Qt5::Widgets) but still it does not works.
I think QSignalSpy is in QtTest, not QtWidgets.
And try to use new signal syntax in QSignalSpy spy(m_authenticationSession, SIGNAL(completed(bool)));