Differential D21558

[Places Panel] Pass iconName to KFilePlaceEditDialog
ClosedPublic
Actions

Authored by broulik on Jun 3 2019, 10:36 AM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:c43165a1c42f: [Places Panel] Pass iconName to KFilePlaceEditDialog
Summary

Ensures that editing an entry with a custom icon doesn't have its icon discarded.

Test Plan

19.04 branch

  • Created entry, changed icon, edited again, icon was the same

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 3 2019, 10:36 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 3 2019, 10:36 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Jun 3 2019, 10:36 AM
broulik retitled this revision from [Places Panel] Pass existing iconName to to [Places Panel] Pass iconName to KFilePlaceEditDialog.
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Dolphin.
elvisangelaccio accepted this revision.Jun 3 2019, 7:55 PM
This revision is now accepted and ready to land.Jun 3 2019, 7:55 PM
Closed by commit R318:c43165a1c42f: [Places Panel] Pass iconName to KFilePlaceEditDialog (authored by broulik). · Explain WhyJun 4 2019, 6:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/panels/places/placespanel.cpp (3 lines)

Diff 59106

View Options

src/panels/places/placespanel.cpp

Loading...