Differential D2152

Scale pixmap cache of MarbleGraphicsItem
ClosedPublic
Actions

Authored by stassats on Jul 13 2016, 5:22 PM.

Details

Reviewers
nienhueser
rahn
Group Reviewers
Marble
Commits
R34:17c73b120bfe: Scale pixmap cache of MarbleGraphicsItem
R34:5b194b02ead2: Scale pixmap cache of MarbleGraphicsItem
Summary

Use devicePixelRatio to properly scale cached pixmaps on HiDPI screens.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
stassats updated this revision to Diff 5127.Jul 13 2016, 5:22 PM
stassats retitled this revision from to Scale pixmap cache of MarbleGraphicsItem.
stassats updated this object.
stassats edited the test plan for this revision. (Show Details)
stassats added reviewers: Marble, nienhueser, rahn.
stassats set the repository for this revision to R34 Marble.
rahn edited edge metadata.Jul 13 2016, 5:27 PM

Looks good to me

nienhueser added inline comments.Jul 13 2016, 5:51 PM
src/lib/marble/graphicsview/MarbleGraphicsItem.cpp
62

I think the bracket is wrong, the + QSize(1,1) should be done outside (after the scale multiplication)

stassats updated this revision to Diff 5130.Jul 13 2016, 5:59 PM
stassats edited edge metadata.

Compare the scale when looking up cached pixmaps.

stassats updated this revision to Diff 5131.Jul 13 2016, 6:09 PM

Add the rounding error pixel after the size is scaled.

nienhueser accepted this revision.Jul 13 2016, 6:15 PM
nienhueser edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 13 2016, 6:15 PM
rahn accepted this revision.Jul 14 2016, 1:47 PM
rahn edited edge metadata.
kossebau added a subscriber: kossebau.Sep 10 2016, 3:23 PM

@stassats Has this not landed yet because you do not have KDE git push rights? Shall I land this for you?

Closed by commit R34:17c73b120bfe: Scale pixmap cache of MarbleGraphicsItem (authored by stassats, committed by kossebau). · Explain WhySep 20 2016, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5131

View Options

src/lib/marble/graphicsview/MarbleGraphicsItem.cpp

Loading...