Differential D21483

Don't modify a temporary object
ClosedPublic
Actions

Authored by apol on May 29 2019, 2:27 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:0b18d4f0b38c: Don't modify a temporary object
Summary

Instead copy the object, operate it and update it into the object.

Test Plan

just used plasma shell and ran the tests. I'm not sure who uses this.
Issue found with clazy.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.May 29 2019, 2:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 29 2019, 2:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.May 29 2019, 2:27 PM
apol updated this revision to Diff 58845.May 29 2019, 2:28 PM

arcanist decided to also push a bunch of unrelated stuff :(

davidedmundson accepted this revision.May 30 2019, 12:59 PM
This revision is now accepted and ready to land.May 30 2019, 12:59 PM
Closed by commit R242:0b18d4f0b38c: Don't modify a temporary object (authored by apol). · Explain WhyMay 30 2019, 1:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58909

View Options

src/plasma/private/storagethread.cpp

Loading...