Details
Details
- Reviewers
- None
- Group Reviewers
KDE PIM - Commits
- R94:cbeeed20d857: Cleanup headerstyle_util interface.
Diff Detail
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I assume you checked that everything still builds? I see some reference to this method in kdepim-addons?
Comment Actions
Yes I know, that kdepim-addons needs to be updated, too. But it is easier for me first to ask for changes in messagelib and if they are approved update kdepim-addons in one row.
Comment Actions
So why do you want to remove it in the first place, if you know there's a code in a header style plugin that uses those methods? And what is your proposed fix for kdepim-addons?
Comment Actions
I can understand your comments. I want simple cleanup code, as everything should use the new interface. Additionally I wanted to express myself, that I plan to remove this. Maybe I start to mark those function as deprecated. And request the removal, when code in kdepim-addons is changed.