WIP: Cleanup headerstyle_util interface.
ClosedPublic

Authored by knauss on May 28 2019, 10:11 AM.

Details

Reviewers
None
Group Reviewers
KDE PIM
Commits
R94:cbeeed20d857: Cleanup headerstyle_util interface.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.May 28 2019, 10:11 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 28 2019, 10:11 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.May 28 2019, 10:11 AM

I assume you checked that everything still builds? I see some reference to this method in kdepim-addons?

I assume you checked that everything still builds? I see some reference to this method in kdepim-addons?

Yes I know, that kdepim-addons needs to be updated, too. But it is easier for me first to ask for changes in messagelib and if they are approved update kdepim-addons in one row.

So why do you want to remove it in the first place, if you know there's a code in a header style plugin that uses those methods? And what is your proposed fix for kdepim-addons?

knauss retitled this revision from Cleanup headerstyle_util interface. to WIP: Cleanup headerstyle_util interface..Jun 24 2019, 11:35 AM

So why do you want to remove it in the first place, if you know there's a code in a header style plugin that uses those methods? And what is your proposed fix for kdepim-addons?

I can understand your comments. I want simple cleanup code, as everything should use the new interface. Additionally I wanted to express myself, that I plan to remove this. Maybe I start to mark those function as deprecated. And request the removal, when code in kdepim-addons is changed.

Indeed, that would be a better approach. 👍

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2019, 10:37 PM
This revision was automatically updated to reflect the committed changes.