Differential D21431

[kaccess] Don't talk to ksmserver
ClosedPublic
Actions

Authored by broulik on May 27 2019, 3:16 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Maniphest Tasks
T10958: Faster Startup
Commits
R119:43b8cab44b6c: [kaccess] Don't talk to ksmserver
Summary

We don't need any of its session restoration capabilities but it still talks to ksmserver just to then have us discard all the info anyway.

Test Plan
  • Sent sigstop to ksmserver, started kaccess, started fine now.

It doesn't seem to spawn any processes (KRun or QProcess) other than running gsettings (lol) for screen reader

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 27 2019, 3:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 27 2019, 3:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 27 2019, 3:16 PM
broulik edited the test plan for this revision. (Show Details)
ngraham added a task: T10958: Faster Startup.May 28 2019, 3:26 AM
ngraham edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.May 28 2019, 8:11 AM

kaccess is invoked by kcminit which currently happens before ksmserver...at best it was racy.
May as well make is explicit.

This revision is now accepted and ready to land.May 28 2019, 8:11 AM
Closed by commit R119:43b8cab44b6c: [kaccess] Don't talk to ksmserver (authored by broulik). · Explain WhyMay 28 2019, 8:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkaccess/main.cpp (10 lines)

Diff 58748

View Options

kaccess/main.cpp

Loading...