Export SortFilterModel sort column to QML
ClosedPublic
Actions

Authored by davidedmundson on May 26 2019, 6:31 PM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

R242:39d1db6e49da: Export SortFilterModel sort column to QML

Test Plan

Used in model

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.May 26 2019, 6:31 PM

broulik added a subscriber: broulik.

broulik added inline comments.

src/declarativeimports/core/datamodel.cpp
197	please add a `sortOrderChanged` signal (in a separate patch, if you feel like it)

This revision is now accepted and ready to land.May 26 2019, 8:20 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarativeimports/core/datamodel.h (8 lines)
M			src/declarativeimports/core/datamodel.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58691	cb8bdb8		May 26 2019, 6:31 PM	★	★
Diff 2	58702	e99f653	R242:39d1db6e49da6b5394877c8c501799b63f0f50f1	May 27 2019, 7:03 AM	★	★