Use json loading for Part
ClosedPublic

Authored by elvisangelaccio on Jul 11 2016, 8:58 PM.

Details

Summary

Every time we do a 'make install' we also update the mime database (because we
install mimetypes) and this causes the ksycoca file to be regenerated the
next time we run Ark (because we load the Part using KService).

This is annoying and clutters the console output with ksycoca messages. We can use instead the new
json loading mechanism like we already do with our plugins.

Regarding ark_part.desktop, we continue to install it because Konqueror is
probably using it.

Test Plan

Make sure Ark loads the Part on startup. Check the generated part/ark_part.json
file in the build directory.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Use json loading for Part.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptJul 11 2016, 8:58 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Jul 12 2016, 4:23 PM
rthomsen edited edge metadata.

Nice work! :)

This revision is now accepted and ready to land.Jul 12 2016, 4:23 PM
This revision was automatically updated to reflect the committed changes.