Fix default crosshair having an offset
ClosedPublic

Authored by kossebau on Jul 11 2016, 4:45 PM.

Details

Summary

Code assumed all images used for the crosshair have a size of 21x21.
The default image though is a PNG of a pre-rendered crosshair with a shadow,
which thus is not of that size.
That pre-rendered image, crosshairs-darkened.png, also had a size of 32x32,
while the crosshair in it had a pixel width of 1, so it's center would
not be pixel aligned with the cross lines. Image now resized to have
crosshair in the middle pixels.

Test Plan

Crosshair now is centered on middle, tested e.g. with 0, 0 lonlat.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 5079.Jul 11 2016, 4:45 PM
kossebau retitled this revision from to Fix default crosshair having an offset.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: Marble, rahn, nienhueser.
nienhueser accepted this revision.Jul 11 2016, 7:47 PM
nienhueser edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jul 11 2016, 7:47 PM
rahn accepted this revision.Jul 11 2016, 7:49 PM
rahn edited edge metadata.

Looks good

This revision was automatically updated to reflect the committed changes.