Prevent the Yakuake Task from Showing up in the Task Bar
Needs ReviewPublic

Authored by fstpierre on May 23 2019, 3:53 AM.

Details

Reviewers
hein
Group Reviewers
Yakuake
Summary

BUG: 361725
I have noticed that when Yakuake appears in the task Bar. Modifying a setting in the configuration menu then clicking Apply made it disappear.

By calling applyWindowProperties in sharedAfterOpenWindow(), Yakuake appearing in the task bar. This function is responsible for setting the state NET::SkipTaskbar along some of the other states defined by the user's properties.

Test Plan

Repeatedly hide and show Yakuake.

Diff Detail

Repository
R369 Yakuake
Lint
Lint Skipped
Unit
Unit Tests Skipped
fstpierre requested review of this revision.May 23 2019, 3:53 AM
fstpierre created this revision.
hein added a comment.May 23 2019, 6:12 AM

It's not that easy I'm afraid.

applyWindowProperties is already called in MainWindow::event on both QEvent::Expose and QEvent::PlatformSurface, which is identical to the code I wrote for Plasma::Dialog, where it seems to work reliably. The problems here are two-fold - for one, the window state should actually never get lost in the first place; it's a Qt issue that it is. But also the existing call sites should work fine, and that they don't is a race condition someone needs to investigate properly, or it's just papering over the actual bug.