Fix the logic for Maximize / Minimize

Authored by tcanabrava on May 20 2019, 2:37 PM.



The old logic is good but the splitters don't hide
themselves if all children is hidden, so we need to
hide them again.

Test Plan

The terminals seems a bit "cut" after restoration (this actually hits me with anything that shows / hides a session. @hindenburg any hint to fix this behavior completely?

Diff Detail

R319 Konsole
No Linters Available
No Unit Test Coverage
Build Status
Buildable 11989
Build 12007: arc lint + arc unit
tcanabrava created this revision.May 20 2019, 2:37 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 20 2019, 2:37 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.May 20 2019, 2:37 PM
tcanabrava edited the test plan for this revision. (Show Details)May 20 2019, 3:02 PM
tcanabrava added reviewers: ngraham, hindenburg, Konsole.
tcanabrava added a subscriber: hindenburg.

This doesn't seem to maximize now. I'm not clear on why the splits need a maximize. I can't figure how to un-maximize the view.

As far as the 'cutting', yes I notice it as well when having text on the screen and doing a split-view. The old code had the same issue.

Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)

tcanabrava abandoned this revision.Jun 3 2019, 2:13 PM

Moving to gitlab