Fix memory leak
Needs ReviewPublic

Authored by tcanabrava on May 17 2019, 7:37 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Repository
R108 KWin
Branch
memoryLeak
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11902
Build 11920: arc lint + arc unit
tcanabrava created this revision.May 17 2019, 7:37 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 17 2019, 7:37 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
tcanabrava requested review of this revision.May 17 2019, 7:37 PM
apol added a subscriber: apol.May 17 2019, 7:46 PM
apol added inline comments.
xkb.cpp
297

How about using QScopedPointer<>?

davidedmundson added inline comments.
xkb.cpp
297

The handle must remain valid for the non-error case and last the lifespan of this class.