Make orientation of position marker same as orientation of route if user is on the route itself
ClosedPublic
Actions

Authored by sanjibanb on Jul 9 2016, 8:24 PM.

Details

Reviewers

nienhueser
rahn

Repository

R34 Marble

Lint

Lint Skipped

Unit

Unit Tests Skipped

sanjibanb retitled this revision from to Make orientation of position marker same as orientation of route if user is on the route itself.

sanjibanb updated this object.

sanjibanb edited the test plan for this revision. (Show Details)

sanjibanb set the repository for this revision to R34 Marble.

sanjibanb added a project: Marble.

sanjibanb added a subscriber: Marble.

src/lib/marble/routing/RouteSegment.cpp
211	I think there should be a check at the start of the method that m_path has at least size 2. If not, return 0.

Add check for size of path, before calculating direction.

sanjibanb marked an inline comment as done.Jul 9 2016, 8:37 PM

Looks great, please push :-)

This revision is now accepted and ready to land.Jul 9 2016, 8:43 PM

Thanks! :)

			Path	Packages
M			src/lib/marble/declarative/MarbleQuickItem.cpp (11 lines)
M			src/lib/marble/routing/RouteSegment.h (2 lines)
M			src/lib/marble/routing/RouteSegment.cpp (24 lines)