Differential D21236

Fix crashes with Qt 5.12
ClosedPublic
Actions

Authored by wbauer on May 15 2019, 7:31 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R201:cfb973c74fec: Fix crashes with Qt 5.12
Summary

Commit 1ccd6815 moved the creation of the mNetworkAccessManager down without a mentioned reason,
but that apparently causes crashes with Qt 5.12 at least.

Moving it back to the top seems to fix that.

BUG: 371511

Test Plan

Open and close tabs a couple of times.

Akregator would soon crash here (with Qt 5.12.3), at the second or third time at the latest.
With this patch, no crashes anymore.

Haven't tested it with Qt 5.13 though.

Diff Detail

Repository
R201 Akregator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.May 15 2019, 7:31 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 15 2019, 7:31 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
wbauer requested review of this revision.May 15 2019, 7:31 PM
wbauer edited the summary of this revision. (Show Details)May 15 2019, 7:34 PM
dvratil accepted this revision.May 21 2019, 2:03 PM
dvratil added a subscriber: dvratil.

Hmm, I wonder how this fixes the crash, but WebEngine is magic (plus this looks "harmless")

This revision is now accepted and ready to land.May 21 2019, 2:03 PM
Closed by commit R201:cfb973c74fec: Fix crashes with Qt 5.12 (authored by wbauer). · Explain WhyMay 21 2019, 4:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58421

View Options

src/articleviewer-ng/webengine/articleviewerwebengine.cpp

Loading...