Improve checksums calculation
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 8 2016, 9:50 PM.

Details

Reviewers

rthomsen

Commits

R36:fefce76c92fc: Improve checksums calculation

Summary

Compute also the MD5 in another thread (useful if the archive is huge)
Drop the member QByteArray. If the archive is huge this could be bad on systems with low amount of RAM. QCryptographicHash accepts a QIODevice, so we can just read the file three times.

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio retitled this revision from to Improve checksums calculation.

elvisangelaccio updated this object.

Restricted Application added a project: Ark. · View Herald TranscriptJul 8 2016, 9:50 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Looks good :)

This revision is now accepted and ready to land.Jul 9 2016, 1:42 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kerfuffle/propertiesdialog.h (13 lines)
M			kerfuffle/propertiesdialog.cpp (56 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5031	ffd58b0		Jul 8 2016, 9:50 PM	★	★
Diff 2	5045	ffd58b0	rARKfefce76c92fc30aca8cd775f0e5f4072dd1d5f53	Jul 9 2016, 4:47 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
cfb0ff58b7b0	fd94bd7a3b66	c685adaf5adc	Elvis Angelaccio	cleanup	Jul 8 2016, 9:34 PM
c685adaf5adc	54583ab38420	ff87368c2972	Elvis Angelaccio	work++	Jul 8 2016, 9:19 PM
ff87368c2972	b94bfe8702d4	ffd58b00ed01	Elvis Angelaccio	Work	Jul 8 2016, 5:26 PM