Differential D21191

[Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI
ClosedPublic
Actions

Authored by ngraham on May 13 2019, 5:01 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R114:e6ad673c26b2: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI
Summary
  • Port to QQC2
  • Use Kirigami SwipeListItem for the paths view
  • Use standard import names
  • Put the buttons below the lists to follow the general style
Test Plan

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.May 13 2019, 5:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2019, 5:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 13 2019, 5:01 PM
ndavis added a subscriber: ndavis.May 15 2019, 2:13 AM

Does the button to remove items show up on hover? I don't see it anywhere.

ngraham added a comment.May 15 2019, 2:25 AM

It does on the desktop, yes. On mobile, it's always visible.

ngraham added a comment.May 15 2019, 2:25 AM

(Kirigami.SwipeListItem gives us that for free)

ngraham edited the summary of this revision. (Show Details)May 15 2019, 2:26 AM
ndavis added a comment.May 15 2019, 2:40 AM
In D21191#465438, @ngraham wrote:

It does on the desktop, yes. On mobile, it's always visible.

Is this standard behavior now? If not, I'm not sure I like it.

ngraham added a comment.May 15 2019, 2:45 AM

Yeah pretty much. See the new virtual desktops KCM for example. The nice thing about adopting the same API everywhere is that it's easy to change at least!

ndavis accepted this revision.May 15 2019, 2:48 AM

Alright, LGTM then.

This revision is now accepted and ready to land.May 15 2019, 2:48 AM
Closed by commit R114:e6ad673c26b2: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI (authored by ngraham). · Explain WhyMay 15 2019, 2:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58110

View Options

applets/mediaframe/package/contents/ui/ConfigPaths.qml

Loading...