Differential D21187

Replace unneeded KCombo in kateconfig
ClosedPublic
Actions

Authored by michalhumpula on May 13 2019, 3:17 PM.

Details

Reviewers
cullmann
dhaumann
Summary

As requested in https://phabricator.kde.org/D19480, here comes the cleanup.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
michalhumpula created this revision.May 13 2019, 3:17 PM
Restricted Application added a project: Kate. · View Herald TranscriptMay 13 2019, 3:17 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
michalhumpula requested review of this revision.May 13 2019, 3:17 PM
dhaumann accepted this revision.May 13 2019, 4:10 PM
dhaumann added a subscriber: dhaumann.

Thanks for this follow-up change, please commit!

This revision is now accepted and ready to land.May 13 2019, 4:10 PM
dhaumann added a comment.May 14 2019, 1:21 PM

Btw, slightly related: there is a bug report saying it does not work in all cases: https://bugs.kde.org/show_bug.cgi?id=407512
Maybe you want, you can have a look at this as well.

michalhumpula added a comment.May 14 2019, 5:07 PM
In D21187#465215, @dhaumann wrote:

Btw, slightly related: there is a bug report saying it does not work in all cases: https://bugs.kde.org/show_bug.cgi?id=407512
Maybe you want, you can have a look at this as well.

Ah, I was afraid of something like that. I will try to look at it. Sorry for the problems. Please be patient with me.

Revision Contents
Changeset List

PathPackages
Mkate/kateconfigdialog.h (4 lines)
Mkate/kateconfigdialog.cpp (6 lines)

Diff 58008

View Options

kate/kateconfigdialog.h

Loading...
View Options

kate/kateconfigdialog.cpp

Loading...