search in the new location for knsrc files
ClosedPublic
Actions

Authored by mart on May 13 2019, 11:06 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

search in the new knsrc location, still fallback to the old one for
compatibility

Test Plan

tested with files in both locations

Repository

R252 Framework Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mart requested review of this revision.May 13 2019, 11:06 AM

leinir requested changes to this revision.May 13 2019, 11:42 AM

leinir added a subscriber: leinir.

leinir added inline comments.

src/kpackage-install-handlers/kns/main.cpp
50–58	Since frameworkintegration requires KNewStuff (and Frameworks 5.58), i'd probably suggest using the static function in KNewStuffCore::Engine which gives you this information without having to do manual heuristic type stuff :) static QStringList Engine::configSearchLocations(bool includeFallbackLocations = false): https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1Engine.html#a030b62a72c0c486939461983e225bb49
122	Did you mean to leave this in?

This revision now requires changes to proceed.May 13 2019, 11:42 AM

use configSearchLocations

In the words of the interwebs whenever someone days a certain number: nice :)

This revision is now accepted and ready to land.May 13 2019, 11:55 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kpackage-install-handlers/kns/main.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57993	fd4e91e		May 13 2019, 11:06 AM	★	★
Diff 2	57997	fd4e91e	use configSearchLocations	May 13 2019, 11:52 AM	★	★
Diff 3	58001	fd4e91e	R252:e0df1f28231c54d0f92213b2a62428df578e581a	May 13 2019, 11:59 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e9cda2fbe773	bcc90e9b8b03	fd4e91e90b8b	Marco Martin	search in the new location for knsrc files (Show More…)	May 13 2019, 11:05 AM