Differential D21175

FrameSvgPrivate::generateBackground: generate background also if reqp != p
ClosedPublic
Actions

Authored by kossebau on May 13 2019, 12:01 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:6af447a84867: FrameSvgPrivate::generateBackground: generate background also if reqp != p
Summary

d8a1a9eb084b19e552c789244267f7346e1b27a8 changed the condition from
hasElementPrefix(q->prefix()) to hasElementPrefix(frame->requestedPrefix)
but it is not clear why, as the background is generated from the prefix
data & the requestedPrefix is no-where in effect.
As a result sometimes the background is not rendered for a given
not-existing requestedPrefix which was mapped to an empty prefix instead.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 13 2019, 12:01 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 13 2019, 12:01 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 13 2019, 12:01 AM
mart accepted this revision.May 14 2019, 1:59 PM
This revision is now accepted and ready to land.May 14 2019, 1:59 PM
Closed by commit R242:6af447a84867: FrameSvgPrivate::generateBackground: generate background also if reqp != p (authored by kossebau). · Explain WhyMay 14 2019, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (2 lines)

Diff 58085

View Options

src/plasma/framesvg.cpp

Loading...