Differential D21172

FrameSvg: also clear mask cache on clearCache()
ClosedPublic
Actions

Authored by kossebau on May 12 2019, 11:27 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:f008615e3710: FrameSvg: also clear mask cache on clearCache()
Summary

It can be unexpected that those are not reset when clearCache() was called.

With the current logic when a theme changes the mask cache not reset also
results in wrong lookups, as the cacheid used as key does not include the
theme name.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 12 2019, 11:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 12 2019, 11:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 12 2019, 11:27 PM
davidedmundson accepted this revision.May 13 2019, 8:18 AM
This revision is now accepted and ready to land.May 13 2019, 8:18 AM
Closed by commit R242:f008615e3710: FrameSvg: also clear mask cache on clearCache() (authored by kossebau). · Explain WhyMay 14 2019, 3:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (2 lines)

Diff 58087

View Options

src/plasma/framesvg.cpp

Loading...