Differential D21119

[JobDialog] Also signal cancellation when window is closed by the user
ClosedPublic
Actions

Authored by broulik on May 10 2019, 10:30 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R495:b70018ee4b3e: [JobDialog] Also signal cancellation when window is closed by the user
Summary

This signal is emitted when the user tries to close the window manually, not when doing it programmatically.

Test Plan

Asked it to share to kde connect, closed the window, got a cancellation signalled
Asked it to share to kde connect, accepted task, task succeeded

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 10 2019, 10:30 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 10 2019, 10:30 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.May 10 2019, 10:30 AM
apol accepted this revision.May 10 2019, 11:38 AM
This revision is now accepted and ready to land.May 10 2019, 11:38 AM
Closed by commit R495:b70018ee4b3e: [JobDialog] Also signal cancellation when window is closed by the user (authored by broulik). · Explain WhyMay 13 2019, 7:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/JobDialog.qml (4 lines)

Diff 57980

View Options

src/widgets/JobDialog.qml

Loading...