Fix KAr
ClosedPublic

Authored by aacid on May 9 2019, 10:25 PM.

Details

Reviewers
apol
Commits
R243:79446284aec2: Fix KAr
Summary

The bytearray needs to be 60 long if we read 60 chars not 61, otherwise
when doing endsWith it compares to the last uninitialized char and it's
always false

Comes with an unittest to prove it can at least open a simple .a archive
with two files inside

It has been broken for 6 years so probably noone cares, but better to
have it working ^_^

Diff Detail

Repository
R243 KArchive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.May 9 2019, 10:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 9 2019, 10:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.May 9 2019, 10:25 PM
apol accepted this revision.May 9 2019, 11:13 PM
This revision is now accepted and ready to land.May 9 2019, 11:13 PM
This revision was automatically updated to reflect the committed changes.