FrameSvg: l & r borders or t & b don't need to have same height resp. width
ClosedPublic

Authored by kossebau on May 9 2019, 8:19 PM.

Details

Summary

The specification for FrameSvg does not require that all borders exist
or that left & right and top & bottom borders have samples with the same
size in the scalable dimension.
The old assumption in the code broke e.g. themes which had special
variants per screen side for the panel-background and left out elements
for the border side which would not be rendered anyway, but only set a
margin-hint. So e.g. for a panel on the east screen edge, without the
left border element set, leftHeight would be 0 and as result also the
right border not be painted due to an empty size.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 9 2019, 8:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 9 2019, 8:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 9 2019, 8:19 PM
apol accepted this revision.May 9 2019, 11:07 PM
This revision is now accepted and ready to land.May 9 2019, 11:07 PM
This revision was automatically updated to reflect the committed changes.