Differential D21088

[quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic
Actions

Authored by ngraham on May 8 2019, 8:40 PM.

Details

Reviewers
filipf
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R114:12eba77542c1: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI
Summary
  • Port to QQC2+Kirigami FormLayout style
  • Use standard import names
  • Adjust some strings to sound a bit more natural
  • Use Kirigami ActionTextField so that the text field can have a clear button
  • Fix a bug preventing the text field from being disabled once enabled
Test Plan
  • All features still work
  • Settings are saved and loaded correctly

On the desktop:

In a horizontal panel:

In a vertical panel:

Diff Detail

Repository
R114 Plasma Addons
Branch
quicklaunch-modernize-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11677
Build 11695: arc lint + arc unit
ngraham created this revision.May 8 2019, 8:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 8 2019, 8:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 8 2019, 8:40 PM
filipf added a subscriber: filipf.May 8 2019, 8:48 PM

Hmm I can't set the number of columns anymore when in vertical position.

Before:

ngraham updated this revision to Diff 57784.May 8 2019, 8:54 PM

Fix embarrassing error

ngraham added a comment.May 8 2019, 8:55 PM

Oops, how embarrassing. I had misunderstood the feature somehow. Fixed!

filipf accepted this revision.May 8 2019, 9:04 PM

Everything looks good to me now!

This revision is now accepted and ready to land.May 8 2019, 9:04 PM
Closed by commit R114:12eba77542c1: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). · Explain WhyMay 8 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57784

View Options

applets/quicklaunch/package/contents/ui/ConfigGeneral.qml

Loading...