Differential D21067

Statusbar progress widget: update up/down icon when dialog goes away
ClosedPublic
Actions

Authored by dfaure on May 7 2019, 9:27 AM.

Details

Reviewers
mlaurent
dvratil
Commits
R89:8315fe4be9ef: Statusbar progress widget: update up/down icon when dialog goes away
Summary

The two need to always be in sync. The button was still showing "down"
when the dialog went away with a timer.

Since slotToggleVisibility() ends up calling StatusbarProgressWidget::slotProgressDialogVisible
slotProgressButtonClicked() doesn't need to updateProgressButton() directly.

Test Plan

Looking at the button at the end of a sync

Diff Detail

Branch
statusbarprogresswidget_cleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11629
Build 11647: arc lint + arc unit
dfaure requested review of this revision.May 7 2019, 9:27 AM
dfaure created this revision.
dvratil accepted this revision.May 7 2019, 5:13 PM
This revision is now accepted and ready to land.May 7 2019, 5:13 PM
dfaure closed this revision.May 9 2019, 5:25 PM

Revision Contents
Changeset List

Diff 57705

View Options

src/libkdepim/progresswidget/statusbarprogresswidget.h

Loading...
View Options

src/libkdepim/progresswidget/statusbarprogresswidget.cpp

Loading...