Differential D21064

[effects/cubeslide] Cancel active animation when number of desktops has changed
ClosedPublic
Actions

Authored by zzag on May 7 2019, 9:21 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:e8b45cce1168: [effects/cubeslide] Cancel active animation when number of desktops has changed
Summary

If a virtual desktop is removed, then desktopChanged will be followed by
numberDesktopsChanged signal. In which case, we have to cancel the
active animation because front_desktop might be no longer valid when
it's time to perform compositing.

BUG: 406452

Diff Detail

Repository
R108 KWin
Branch
cancel-cube-slide-animation
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11626
Build 11644: arc lint + arc unit
zzag created this revision.May 7 2019, 9:21 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 7 2019, 9:21 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 7 2019, 9:21 AM
davidedmundson accepted this revision.May 7 2019, 10:56 AM
This revision is now accepted and ready to land.May 7 2019, 10:56 AM
Closed by commit R108:e8b45cce1168: [effects/cubeslide] Cancel active animation when number of desktops has changed (authored by zzag). · Explain WhyMay 7 2019, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57702

View Options

effects/cubeslide/cubeslide.h

Loading...
View Options

effects/cubeslide/cubeslide.cpp

Loading...